Merged
Conversation
Rather than separately pulling 0.2 and 0.4 versions.
Otherwise we can't return a future due to borrow on Endpoint::incoming
The former uses Tokio 0.2
Contributor
Author
|
It seems this only needs a second, separate approval and should be good to go 🎉 |
Contributor
|
Yeah, I will review it, latest on Monday. |
niklasad1
reviewed
Jan 11, 2021
| tokio-util = { version = "0.3", features = ["codec"] } | ||
|
|
||
| [dev-dependencies] | ||
| tokio = { version = "0.2", features = ["rt-core", "macros"] } |
Contributor
There was a problem hiding this comment.
these dev-dependencies will leaked into the release build, however rust-lang/cargo#8997 have been stabalized so should be included in the next Rust release I guess.
niklasad1
reviewed
Jan 11, 2021
tcp/src/server.rs
Outdated
| @@ -1,14 +1,14 @@ | |||
| use std; | |||
Contributor
There was a problem hiding this comment.
Suggested change
| use std; |
niklasad1
approved these changes
Jan 11, 2021
Contributor
niklasad1
left a comment
niklasad1
left a comment
There was a problem hiding this comment.
Nice work LGTM, I didn't review it super carefully except the Windows mio hacks.
Contributor
Author
|
While going through the diff again I noticed that I removed a Tokio re-export in ipc server - rolled that back in a05cd4e by adding the re-export. Since this is all green, I'm merging it. Thank you for taking your time to review this! |
This was referenced Jan 15, 2021
This was referenced Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivated to migrate RLS off Tokio 0.1 for IPC transport but since we're at it, it might make sense to migrate everything else in one fell swoop.
This is a very early draft but opening it now to prevent duplicating work in case someone else starts working in it (or would like to help 😁).Fixes #582
Fixes #485